Prevents a workspace from depending on itself#6572
Open
ReDrUm wants to merge 6 commits intoyarnpkg:masterfrom
Open
Prevents a workspace from depending on itself#6572ReDrUm wants to merge 6 commits intoyarnpkg:masterfrom
ReDrUm wants to merge 6 commits intoyarnpkg:masterfrom
Conversation
ReDrUm
force-pushed
the
disallow-self-ref-deps
branch
from
a67978f to
fe7c912
Compare
ReDrUm
changed the title
ReDrUm
force-pushed
the
disallow-self-ref-deps
branch
3 times, most recently
from
5e0794b to
579d894
Compare
ReDrUm
force-pushed
the
disallow-self-ref-deps
branch
from
579d894 to
921747a
Compare
Contributor
Author
|
Ready for review please. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Within a monorepo I've encountered a few
package.jsonfiles that erroneously depend on themselves. Obviously an accident. This seems like an easy thing for the automaticpackage.jsonsanitization to cleanup, alongside the other checks it performs.The circular dependency can negatively affect install time performance and other tooling that use the
package.jsondependencies as the source of truth for dependency graph analysis....
How did you fix it?
Updated the manifest to delete self referencing dependencies to the existing package name. When
Workspace.persistManifestis called thepackage.jsonwill be rewritten to remove them.Similar to #421, except this will cleanup files that were manually added (rather than via
yarn add), and handle cleaning up preexisting matches....
Checklist