Fix single star into double star#7
Open
klauspost wants to merge 1 commit into
Open
Conversation
Single star into double star did not work as expected. Pattern `a/b/*/e.f/**` would not match `a/b/c/e.f/g` since the top level glob would be performed on a path ending with a `/`. Using `filepath.Join(match, glob)` will remove the trailing slash. Two tests included for regression tests. And as a side bonus tests will now also pass on Windows.
klauspost
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Single star into double star did not work as expected.
Pattern
a/b/*/e.f/**would not matcha/b/c/e.f/gsince the top level glob would be performed on a path ending with a/. Usingfilepath.Join(match, glob)will remove the trailing slash.Two tests included for regression tests. And as a side bonus tests will now also pass on Windows.