Skip to content

#2228: Add cancelation of the geant4 simulation #2310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
grzanka merged 4 commits into from
Dec 20, 2025
Merged

#2228: Add cancelation of the geant4 simulation #2310

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3dda40a
Add cancelation of the geant4 simulation
lkwinta Dec 19, 2025
8c07156
Fix dissappeering of simulation info after canceling
lkwinta Dec 19, 2025
0348baf
Revert converter
lkwinta Dec 19, 2025
15a8c50
Address @kmichalik review
lkwinta Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libs/converter
Open in desktop
Submodule converter updated 1 files
+2 −2 .github/workflows/test-run.yml
9 changes: 8 additions & 1 deletion src/services/Geant4LocalWorkerSimulationService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -536,6 +536,13 @@ export default class Geant4LocalWorkerSimulationService implements SimulationSer
}

cancelJob(info: SimulationInfo, signal?: AbortSignal | undefined): Promise<void> {
throw new Error('Method not implemented.');
const { jobId } = info;

if (this.workers.hasOwnProperty(jobId)) {
this.workers[jobId].markSafeForTermination();
delete this.workers[jobId];
}

return Promise.resolve();
}
}
Loading