-
Notifications
You must be signed in to change notification settings - Fork 5
Add option to download full datasets prior to simulation #2246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 13 out of 13 changed files in this pull request and generated 7 comments.
Comments suppressed due to low confidence (1)
src/WrapperApp/components/Simulation/Geant4DatasetDownload.tsx:14
- Unused import CircularProgress.
import {
AccordionDetails,
AccordionSummary,
Box,
Button,
CircularProgress,
LinearProgress,
Typography,
useTheme
} from '@mui/material';
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
41f16f6 to
aea9774
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
src/WrapperApp/components/Simulation/RunSimulationForm.tsx:434
- This use of variable 'inputFiles' always evaluates to true.
{Object.keys(inputFiles ?? {}).map((fileName, index) => (
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 16 out of 16 changed files in this pull request and generated 5 comments.
Comments suppressed due to low confidence (6)
src/Geant4Worker/Geant4Worker.ts:171
- Missing early return after error message when deps are already loaded. This allows the code to continue and potentially reload deps, which could cause issues. Add
return;after the console.error statement.
if (this.depsLoaded) {
console.error('Deps already loaded');
}
src/Geant4Worker/Geant4Worker.ts:189
- Missing early return after error message when deps are already loaded. This allows the code to continue and potentially reload deps lazily, which could cause issues. Add
return;after the console.error statement.
if (this.depsLoaded) {
console.error('Deps already loaded');
}
src/WrapperApp/components/Simulation/Geant4DatasetDownload.tsx:5
- Unused import HelpOutlineIcon.
import HelpOutlineIcon from '@mui/icons-material/HelpOutline';
src/WrapperApp/components/Simulation/Geant4DatasetDownload.tsx:15
- Unused import Alert.
import {
AccordionDetails,
AccordionSummary,
Alert,
Box,
Button,
LinearProgress,
Typography,
useTheme
} from '@mui/material';
src/WrapperApp/components/Simulation/Geant4DatasetDownload.tsx:16
- Unused import palette.
import { palette } from '@mui/system';
src/WrapperApp/components/Simulation/Geant4DatasetDownload.tsx:70
- Unused function showDetailsModal.
function showDetailsModal() {}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/WrapperApp/components/Simulation/Modal/DatasetsInfoModal.tsx
Outdated
Show resolved
Hide resolved
src/WrapperApp/components/Simulation/Modal/DatasetsInfoModal.tsx
Outdated
Show resolved
Hide resolved
|
@lkwinta can you rebase on top of the newest master ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 17 out of 17 changed files in this pull request and generated 6 comments.
Comments suppressed due to low confidence (1)
src/WrapperApp/components/Simulation/RunSimulationForm.tsx:434
- This use of variable 'inputFiles' always evaluates to true.
{Object.keys(inputFiles ?? {}).map((fileName, index) => (
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 18 out of 18 changed files in this pull request and generated 9 comments.
Comments suppressed due to low confidence (1)
src/WrapperApp/components/Simulation/RunSimulationForm.tsx:434
- This use of variable 'inputFiles' always evaluates to true.
{Object.keys(inputFiles ?? {}).map((fileName, index) => (
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/WrapperApp/components/Simulation/Modal/DatasetsFullInfoModal.tsx
Outdated
Show resolved
Hide resolved
src/WrapperApp/components/Simulation/Modal/DatasetsFullInfoModal.tsx
Outdated
Show resolved
Hide resolved
grzanka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 18 out of 18 changed files in this pull request and generated 12 comments.
Comments suppressed due to low confidence (1)
src/Geant4Worker/Geant4Worker.ts:169
- Inconsistent error handling:
console.erroris used at lines 168 and 184 for the same class in the same file, but at lines 164, 180, 196, and 207, errors are thrown. TheloadDeps()andloadDepsLazy()methods now throw errors (lines 164, 180), which is more appropriate than the previous console.error approach. However,loadDeps()at line 168 still logs to console when deps are already loaded. Consider throwing an error here too for consistency.
if (this.depsLoaded) {
console.error('Deps already loaded');
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/WrapperApp/components/Simulation/Modal/DatasetsPartialInfoModal.tsx
Outdated
Show resolved
Hide resolved
…al.tsx Co-authored-by: Leszek Grzanka <[email protected]>
Co-authored-by: Copilot <[email protected]>
…Modal.tsx Co-authored-by: Copilot <[email protected]>
|
@grzanka I have responded to copilot commends and published latest version on yap-dev |

This pull request introduces a comprehensive system for managing and displaying the download status of Geant4 simulation datasets in the application. It adds new React hooks and UI components for monitoring, controlling, and informing users about dataset downloads, integrates these features into the main simulation workflow, and updates simulation run logic to support dataset selection.
Dataset Download Management and UI Integration
useDatasetDownloadManagerhook inGeant4DatasetDownloadManager.tsto track and control the download status of Geant4 datasets, including polling progress from the worker and updating UI state.Geant4Datasetsfor download controls and status display, andDatasetsInfoDialogmodal for dataset descriptions and download info. [1] [2]WrapperApp.tsx) and simulation panel (RunSimulationForm.tsx), allowing users to start downloads and view progress. [1] [2] [3] [4]Simulation Run Logic Updates
UseRunGeant4LocalWorkerSimulation.tsx,UseRunRemoteWorkerSimulation.tsx) to accept and pass the selectedGeant4DatasetsType, enabling simulations to utilize downloaded datasets. [1] [2] [3] [4]Geant4 Worker and Progress Monitoring Enhancements
Geant4Worker, enabling periodic updates of download status and progress to the UI.Codebase Cleanup
These changes provide users with a clear, interactive way to manage Geant4 dataset downloads, improving simulation speed and reliability while keeping the workflow intuitive.