-
Notifications
You must be signed in to change notification settings - Fork 5
build(workflow): update Node.js version to 22.x and adjust permissions #2047
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
grzanka
merged 7 commits into
master
from
2046-fix-code-scanning-alert---workflow-does-not-contain-permissions
Apr 24, 2025
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
634ff82
build(workflow): update Node.js version to 22.x and adjust permissions
grzanka 878694f
build(deps): update poetry version to 1.8.5
grzanka 78172dc
build(deps): fix poetry installation syntax in buildPython.js
grzanka dde76d5
build(workflow): update Node.js and Python versions in manual_test.yml
grzanka 2f46f7f
build(workflow): restrict operating system to Windows and update npm …
grzanka 02b1596
build(workflow): update Windows build step to run npm build instead o…
grzanka 320180a
build(workflow): add permissions section and enable Ubuntu in the ope…
grzanka File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,6 @@ | ||
| name: On-demand tests | ||
| permissions: | ||
| contents: read # Required for actions/checkout and reading repo content | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
|
|
@@ -10,12 +12,11 @@ env: | |
| jobs: | ||
| build_and_test: | ||
|
|
||
|
|
||
| strategy: | ||
| matrix: | ||
| node-version: [18.x, 20.x, 22.x] | ||
| node-version: [20.x, 22.x] | ||
| operating-system: [ubuntu-latest, windows-latest] | ||
| python-version: ['3.10', '3.11', '3.12'] | ||
| python-version: ['3.11', '3.12'] | ||
| # See supported Node.js release schedule at https://nodejs.org/en/about/releases/ | ||
|
|
||
| runs-on: ${{ matrix.operating-system }} | ||
|
|
@@ -43,17 +44,18 @@ jobs: | |
| if: matrix.operating-system == 'ubuntu-latest' | ||
| run: npm run start & | ||
|
|
||
| - name: Start application in background on Windows | ||
| - name: Test application build on Windows | ||
| if: matrix.operating-system == 'windows-latest' | ||
| run: | | ||
| Start-Process -FilePath "npm" -ArgumentList "run start" -NoNewWindow | ||
| run: npm run build | ||
|
|
||
| - name: Wait for the app to start | ||
| if: matrix.operating-system == 'ubuntu-latest' | ||
| uses: iFaxity/[email protected] | ||
| with: | ||
| resource: http://localhost:3000 | ||
|
|
||
| - name: Run tests | ||
| if: matrix.operating-system == 'ubuntu-latest' | ||
| uses: nick-fields/retry@v3 | ||
| with: | ||
| max_attempts: 2 | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verify that the strict version pin to poetry 1.8.5 is intentional, as the previous version approximation allowed compatible updates.