fetch only one estimator #1790
fetch only one estimator #1790
Conversation
matuszsmig
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
I am using here endpoint created in this PR: yaptide/yaptide#1140 |
|
@matuszsmig can I test it already now ? |
yes |
|
@grzanka do you have any other objections to this PR? |
|
Looks OK, but I got a lot of following errors like:
|
only this one: #1790 (comment) |
|
@matuszsmig Aside from the errors mentioned above, the code looks great from what I've seen. |
It tries to sort data, but whole data isn't fetched yet, so it isn't important. |
|
This PR breaks one essential functionality (which BTW needs to be described in the users manual - will you add an issue on that ?). If user sorts the quantities when defining simulation (Editor \ Scoring \ Outputs), the same order should be used when displaying results. See how it works on production now: Screencast.from.2024-10-21.12-16-51.webmIn the video above I've changed the order of quantities in the simulation definition and the results were presented in a correct way. This is how it behaves in current PR: Screencast.from.2024-10-21.12-19-47.webmI've changed the order of estimators in such way that |
grzanka
left a comment
grzanka
left a comment
There was a problem hiding this comment.
It breaks essential functionality, see my comment here:
#1790 (comment)
|
The order of elements (estimators in results tab) should be extracted from the JSON project only if the user defined project using Editor tab. If the user defined the project using pyodide converter (which alas is undocumented) then the order of elements is not relevant, we display them in same order as they come from backend. See video below: Screencast.from.2024-10-21.12-31-16.webm |
|
@matuszsmig @tudde both options: defining simulation in editor and using pyodide converter needs to be tested to be sure that this PR is OK |
|
Update the documentation here: |
|
On-demand deploy: succeeded ✅ |
matuszsmig
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
The warning: is not yet gone. Try removing Screencast.from.2024-10-22.10-16-46.webmThere are following issues:
Here a detailed logs from |
|
BTW - sorting seems to works, but warning is present. |
That's correct, but you need to have these "Estimator names" for all other simulators (i.e. SHIELD-HIT12A) as well, when running project from the editor. I'd put the Below couple of fragments from For example For SHIELD-HIT12A those two This way you can probably avoid dealing with trailing Lets summarize, if I understand the situation correctly. Master branchFluka project from EditorEstimator names extracted from the output filenames (i.e. 21,22...) SHIELD-HIT12A project from EditorEstimator names extracted from the output filenames (i.e. 'AlongBeamAxis' ) any project from user-uploaded files or pyodide-generated filesEstimator names extracted from the output filenames (i.e. 21,22... for Fluka, 'MyFileName' for SHIELDHIT12A ) This PRFluka project from EditorEstimator names extracted from the Editor project (i.e. 'AlongAxis') SHIELD-HIT12A project from EditorEstimator names extracted from the output filenames (i.e. 'AlongBeamAxis' ) any project from user-uploaded files or pyodide-generated filesEstimator names extracted from the output filenames (i.e. 21,22... for Fluka, 'MyFileName' for SHIELDHIT12A ) Desired stateFluka or SHIELD-HIT12A project from EditorEstimator names extracted from the Editor project (i.e. 'AlongAxis') any project from user-uploaded files or pyodide-generated filesEstimator names extracted from the output filenames (i.e. 21,22... for Fluka, 'MyFileName' for SHIELDHIT12A ) |
|
@matuszsmig cross-check if all the examples have correctly set All examples should be of the same type, namely generated with the Editor. |
matuszsmig
temporarily deployed
to
github-pages
GitHub Actions
Inactive
matuszsmig
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
I've simulated a run with user input files and noticed strange field same for regular simulations: what is that field , why is it in top level ? JSON obtained by Save to file on the Results tab Also - why do we see now pages in top level of saved JSON ? |
|
After clicking on "Save to file" on Simulation Card we will get a JSON with only one estimator saved:
When loading such files in the yaptide (with logged out user) second estimator wants to be downloaded from backend: |
|
@matuszsmig there is this PR #1782 which was merged today - check it if has some effect on your work |
|
I've logged in as an user which has no simulations stored in the DB. I've loaded the example and tried to save it with its results to my hard disk as JSON file. yaptide started to query backend producing a lot of failed POST requests. Screencast.from.2024-12-01.20-54-47.webm |
This pull request introduces several new features and improvements to the
ThreeEditorandWrapperAppcomponents, focusing on enhancing the handling and display of simulation results. The changes include adding new types, updating existing components to fetch job results dynamically, and creating new components for better results presentation.Key Changes:
Enhancements to Simulation Results Handling:
src/ThreeEditor/components/Dialog/SaveFileDialog.tsx: UpdatedSaveFileDialogto fetch job results dynamically if not provided and handle the expected number of estimators. [1] [2] [3] [4]New Components for Result Presentation:
src/WrapperApp/components/Results/EstimatorTab/EstimatorTab.tsx: Added a new componentEstimatorTabto display individual estimator results in a card layout.src/WrapperApp/components/Results/EstimatorsSelect/EstimatorsSelect.tsx: Added a new componentEstimatorsSelectto handle the selection of different estimators and fetch their results dynamically.Updates to Existing Components:
src/WrapperApp/components/Results/ResultsPanel.tsx: RefactoredResultsPanelto use the newEstimatorsSelectandEstimatorTabcomponents, improving the layout and dynamic fetching of estimator data. [1] [2] [3]Service Updates:
src/services/ShSimulatorService.tsx: Introduced new types and methods for fetching specific estimator results and updated existing methods to support these changes. [1] [2] [3] [4]These changes collectively improve the user experience by ensuring that simulation results are fetched and displayed dynamically, providing a more responsive and informative interface.