-
Notifications
You must be signed in to change notification settings - Fork 1
Geant4 parser code decompositon #254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Ciorolla
wants to merge
15
commits into
master
Choose a base branch
from
geant4-parser-code-decompositon
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 14 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
b75f8b2
first version of decomposited converter
Ciorolla 994833b
gdml and macros are now decomposited
Ciorolla abd3652
deepsource complaints fix 1
Ciorolla 72a5fa6
deepsource complaints fix 2
Ciorolla 35e3416
copilot changes resolved
Ciorolla 9b5022d
copilot changes resolved 2
Ciorolla ca01156
deepsource changes resolved 3
Ciorolla 2d4e225
kmichalik code review resolved
Ciorolla 91304f9
Deepsource complaints resolved
Ciorolla 4745614
Kmichalik complaints resolved
Ciorolla 7e13d74
more pythonic code ( functions more, classes less ) :)
Ciorolla 2727caf
more pythonic code ( functions more, classes less ) :)
Ciorolla 98783da
review changes
Ciorolla 658e2ba
review changes
Ciorolla df77d9d
review changes
Ciorolla File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Empty file.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| HEAVY_ION_PARTICLE_ID = 25 | ||
|
|
||
| GEANT4_PARTICLE_MAP = { | ||
| 1: { | ||
| "name": "neutron", | ||
| "allowed_units": ["MeV", "MeV/nucl"], | ||
| "target_unit": "MeV" | ||
| }, | ||
| 2: { | ||
| "name": "proton", | ||
| "allowed_units": ["MeV", "MeV/nucl"], | ||
| "target_unit": "MeV" | ||
| }, | ||
| 3: { | ||
| "name": "geantino", | ||
| "allowed_units": ["MeV"], | ||
| "target_unit": "MeV" | ||
| }, | ||
| 4: { | ||
| "name": "e-", | ||
| "allowed_units": ["MeV"], | ||
| "target_unit": "MeV" | ||
| }, | ||
| 5: { | ||
| "name": "e+", | ||
| "allowed_units": ["MeV"], | ||
| "target_unit": "MeV" | ||
| }, | ||
| 6: { | ||
| "name": "alpha", | ||
| "allowed_units": ["MeV", "MeV/nucl"], | ||
| "target_unit": "MeV" | ||
| }, | ||
| 7: { | ||
| "name": "mu-", | ||
| "allowed_units": ["MeV"], | ||
| "target_unit": "MeV" | ||
| }, | ||
| 8: { | ||
| "name": "mu+", | ||
| "allowed_units": ["MeV"], | ||
| "target_unit": "MeV" | ||
| }, | ||
| 9: { | ||
| "name": "pi-", | ||
| "allowed_units": ["MeV"], | ||
| "target_unit": "MeV" | ||
| }, | ||
| 10: { | ||
| "name": "pi+", | ||
| "allowed_units": ["MeV"], | ||
| "target_unit": "MeV" | ||
| }, | ||
| 11: { | ||
| "name": "geantino", | ||
| "allowed_units": ["MeV"], | ||
| "target_unit": "MeV" | ||
| }, | ||
| HEAVY_ION_PARTICLE_ID: { # equivalent of HEAVYION in other simulators | ||
| "name": "ion", | ||
| "allowed_units": ["MeV", "MeV/nucl"], | ||
| "target_unit": "MeV" | ||
| } | ||
| } | ||
|
|
||
| GEANT4_QUANTITY_MAP = { | ||
| "DoseGy": "doseDeposit", | ||
| "Energy": "energyDeposit", | ||
| "Fluence": "cellFlux", | ||
| "KineticEnergySpectrum": "cellFlux", | ||
| } | ||
|
|
||
| GEANT4_KINETIC_ENERGY_SPECTRUM = "KineticEnergySpectrum" | ||
Empty file.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Particle IDs 3 and 11 both map to the same particle name "geantino" with identical configurations. This appears to be a duplicate entry that could cause confusion or unexpected behavior. If both IDs are intended to map to the same particle, consider adding a comment explaining why; otherwise, one entry may be incorrect.