Skip to content

fix Receiver not registered: com.yanzhenjie.permission.bridge.Messenger #640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix Receiver not registered: com.yanzhenjie.permission.bridge.Messenger #640

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 21 additions & 3 deletions permission/src/main/java/com/yanzhenjie/permission/bridge/Messenger.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,19 +34,37 @@ public static void send(Context context, String suffix) {

private final Context mContext;
private final Callback mCallback;
private boolean mIsRegistered;

public Messenger(Context context, Callback callback) {
this.mContext = context;
this.mCallback = callback;
}

public void register(String suffix) {
IntentFilter filter = new IntentFilter(AndPermission.bridgeAction(mContext, suffix));
mContext.registerReceiver(this, filter);
if (!mIsRegistered) {
IntentFilter filter = new IntentFilter(AndPermission.bridgeAction(mContext, suffix));
mContext.registerReceiver(this, filter);
mIsRegistered = true;
}
}

/*
Fix exception:
Caused by: java.lang.IllegalArgumentException: Receiver not registered: com.yanzhenjie.permission.bridge.Messenger@c949a97
at android.app.LoadedApk.forgetReceiverDispatcher(LoadedApk.java:1471)
at android.app.ContextImpl.unregisterReceiver(ContextImpl.java:1571)
at android.content.ContextWrapper.unregisterReceiver(ContextWrapper.java:664)
at com.yanzhenjie.permission.bridge.Messenger.unRegister(SourceFile:1)
at com.yanzhenjie.permission.bridge.RequestExecutor.onCallback(SourceFile:2)
at com.yanzhenjie.permission.bridge.Messenger.onReceive(SourceFile:1)
at android.app.LoadedApk$ReceiverDispatcher$Args.lambda$getRunnable$0$LoadedApk$ReceiverDispatcher$Args(LoadedApk.java:1620)
*/
public void unRegister() {
mContext.unregisterReceiver(this);
if (mIsRegistered) {
mContext.unregisterReceiver(this);
mIsRegistered = false;
}
}

@Override
Expand Down
16 changes: 9 additions & 7 deletions permission/src/main/java/com/yanzhenjie/permission/bridge/RequestExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,15 +41,17 @@ public RequestExecutor(BridgeRequest request) {

@Override
public void run() {
Context context = mRequest.getSource().getContext();
synchronized (this) {
Context context = mRequest.getSource().getContext();

mMessenger = new Messenger(context, this);
mMessenger.register(getName());
mMessenger = new Messenger(context, this);
mMessenger.register(getName());

Intent intent = new Intent();
intent.setAction(AndPermission.bridgeAction(context, null));
intent.setPackage(context.getPackageName());
context.bindService(intent, mConnection, Service.BIND_AUTO_CREATE);
Intent intent = new Intent();
intent.setAction(AndPermission.bridgeAction(context, null));
intent.setPackage(context.getPackageName());
context.bindService(intent, mConnection, Service.BIND_AUTO_CREATE);
}
}

private ServiceConnection mConnection = new ServiceConnection() {
Expand Down