Improved Logger #49
Open
Improved Logger #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Took pull request #34 and applied requested changes
Collaborator
|
Well ok, I'm currently off schedule due to my exams are near, around mid february. So expect delays. Thanks :) |
So turns out spdlog is not as speedy as I would have liked, after some tinkering, increasing the thread pool from 2 to 4 with a larger queue size improved this, for application performance. However spdlog ignores the flush level for flushing to stdout and stderr (this is dumb). This results in the stdout lagging behind the program MASSIVELY when the program executes quickly (e.g. for running a brainfck program). This would be easily solved if only it respected the flush level (or at least gave to option to)
Owner
Author
|
Might be a good idea to move to the boost logging library instead of spdlog given my discovery in the latest commit evidence |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Took pull request #34 and applied requested changes
Removed the Log.h file as it only added transitive includes, is is meh practice, always good to exclude exactly what you need.
Also added RAII wrapper class around the logger and Get is now GetOrCreate (which will also Init if not already) to handle lifetime.