Skip to content

Premature loading errors fix #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Premature loading errors fix #308

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bf67fe8
Bugfix: fixed TypeError when user data is not ready
Jul 10, 2016
fa05f85
Bugfix: fixed TypeError when user data is not ready
Jul 10, 2016
9fd9934
Revert "Bugfix: fixed TypeError when user data is not ready"
Jul 10, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/typeahead/typeahead.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ angular.module('mm.foundation.typeahead', ['mm.foundation.position', 'mm.foundat
//it might happen that several async queries were in progress if a user were typing fast
//but we are interested only in responses that correspond to the current view value
if (inputValue === modelCtrl.$viewValue && hasFocus) {
if (matches.length > 0) {
if (matches && matches.length > 0) {

scope.activeIdx = 0;
scope.matches.length = 0;
Expand Down Expand Up @@ -304,7 +304,7 @@ angular.module('mm.foundation.typeahead', ['mm.foundation.position', 'mm.foundat
scope.templateUrl = attrs.templateUrl;

scope.isOpen = function () {
return scope.matches.length > 0;
return scope.matches && scope.matches.length > 0;
};

scope.isActive = function (matchIdx) {
Expand Down