found a scenario where the data table search box can't search the val… #2901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ue consisting of '&' though the data exists in the table. Fixed the issue.
yajra
requested changes
Nov 16, 2022
yajra
added a commit
that referenced
this pull request
Nov 17, 2022
yajra
added a commit
that referenced
this pull request
Nov 22, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
|
The changes look good. However, this only changes the filtering keyword. Doing a column search would yield the previous results. Would you be able to review PR #2903? That PR will make the keyword to HTML entities anywhere it is used. Thanks! |
|
Ok, I will review.
…On Fri, Dec 16, 2022 at 12:47 PM Arjay Angeles ***@***.***> wrote:
The changes look good. However, this only changes the filtering keyword.
Doing a column search would yield the previous results.
Would you be able to review this PR #2903
<#2903>? That PR will
make the keyword to HTML entities anywhere it is used.
Thanks!
—
Reply to this email directly, view it on GitHub
<#2901 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACYNNDHMGVLEZLWAZ43WMJTWNQF7NANCNFSM6AAAAAASBFEV44>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Closing in favor of #2903. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ue consisting of '&' though the data exists in the table. Fixed the issue.