Check if the window.performance should be used in a duck-typy way#8
Open
getkey wants to merge 1 commit intoyagl:masterfrom
Open
Check if the window.performance should be used in a duck-typy way#8getkey wants to merge 1 commit intoyagl:masterfrom
window.performance should be used in a duck-typy way#8getkey wants to merge 1 commit intoyagl:masterfrom
Conversation
getkey
force-pushed
the
fix-perf-polyfill
branch
from
dce13ef to
ef331e9
Compare
In my Rollup setup, there is a fake `global` object that is a reference to `window`, which means that the polyfill (meant for Node.js) will be used instead of `window.performance`. I'd rather check if `window` exists and has a `performance()` method, and then only use the polyfill if it's not the case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my Rollup setup, there is a fake
globalobject that is a reference towindow, which means that the polyfill (meant for Node.js) will be used instead ofwindow.performance.I'd rather check if
windowexists and has aperformance()method, and then only use the polyfill if it's not the case.