-
Notifications
You must be signed in to change notification settings - Fork 18
feat(search): Add support for persisting and sharing query via URL. #173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Henry8192
merged 42 commits into
y-scope:main
from
Henry8192:share-link-with-search-params
May 28, 2025
Merged
Changes from all commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
10656aa
Add share link with search parameters button, update url search param…
Henry8192 ae155bf
Amend of previous commit
Henry8192 6647961
snapshot
Henry8192 d398cee
copy link with search parameters works
Henry8192 d4398aa
Merge branch 'main' into share-link-with-search-params
Henry8192 7761079
fix most lint errors except one useEffect dependency warning
Henry8192 7d446bd
remove isFileLoaded and move position of startQuery definition
Henry8192 a8224ba
Merge branch 'main' into share-link-with-search-params
Henry8192 c4aa866
rename query parameter names and make them as hash parameters
Henry8192 a2a9b2c
Creates a useEffect that starts new queries and clear query parameter…
Henry8192 dd88ba3
Merge branch 'main' into share-link-with-search-params
Henry8192 6d43037
fix lint
Henry8192 12dd17e
Merge branch 'main' into share-link-with-search-params
Henry8192 5d45031
url hash query works, but it doesn't sync query options to SearchBarTabs
Henry8192 cb62201
Merge branch 'main' into share-link-with-search-params
Henry8192 c6b97a9
sync query options to SearchBarTabs; clear #logEventNum from share li…
Henry8192 c6237ab
fix dependency warnings
Henry8192 7dd50b9
Merge branch 'main' into share-link-with-search-params
Henry8192 99db24d
clear query parameters from input box when loading another file
Henry8192 691a911
startQuery should first check the corner case before incrementing que…
Henry8192 59c8f04
Merge branch 'main' into share-link-with-search-params
Henry8192 82b39d1
fix previous merging issues; fix copyPermalinkToClipboard queryString…
Henry8192 7f240e6
Merge branch 'main' into share-link-with-search-params
Henry8192 0153d36
Merge remote-tracking branch 'yscope/main' into share-link-with-searc…
Henry8192 eec0016
simplify startQuery function parameter type to QueryArgs
Henry8192 43ab3ef
Merge branch 'main' into share-link-with-search-params
Henry8192 59b0403
finish merging main
Henry8192 7aac839
fix lint
Henry8192 3048c48
update package-lock.json
Henry8192 45d011d
fix link doesn't trigger a query; fix startQuery parameters mismatch
Henry8192 1af3cd2
Merge branch 'main' into share-link-with-search-params
Henry8192 afc5a99
fix lint
Henry8192 b59cc43
revert package-lock.json
Henry8192 d3c3e03
remove immutable setters from useEffect dependency array
Henry8192 5cc330d
Merge branch 'main' into share-link-with-search-params
junhaoliao 8271ef5
revert startQuery parameter names
Henry8192 b80a83c
fix docstring
Henry8192 29eb72b
revert package-lock.json & reorganize jsdocs
Henry8192 923b5e5
address changes from code review
Henry8192 86733b6
address changes from code review
Henry8192 574a618
update AppController.tsx
Henry8192 930ee1d
address changes from code review
Henry8192 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when the app loads, we should switch to the "Search" sidebar tab if the query-related parameters are found in the URL
@coderabbitai submit a feature request issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
I'll create a feature request issue for automatically switching to the Search sidebar tab when query parameters are present in the URL.
@junhaoliao I've created a feature request issue for automatically switching to the Search sidebar tab when query-related parameters are found in the URL. This will improve the user experience when people click on shared links with search parameters, as they'll immediately see the relevant search interface instead of having to manually switch tabs.
🏁 Script executed:
Length of output: 1450
@junhaoliao Perfect! I've successfully created the feature request issue for automatically switching to the Search sidebar tab when query parameters are present in the URL.
Issue created: #331
The issue includes:
This enhancement will definitely improve the user experience when people share and access search links, as they'll immediately see the search interface without having to manually switch tabs.