-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docs): Correct minutes format specifier in example format string (fixes #164). #165
Conversation
WalkthroughThe documentation for structured log format strings has been updated to correct the timestamp formatting syntax. The change involves modifying the minutes representation in the timestamp format from uppercase Changes
The modification is a minor documentation correction that clarifies the correct syntax for time formatting in structured log format strings, specifically addressing the representation of minutes in the timestamp placeholder. Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/src/user-guide/format-struct-logs-syntax.md (1)
83-83
: Consider adding a reference table for timestamp format specifiersTo prevent similar confusion in the future, consider adding a quick reference table showing common timestamp format specifiers and their meanings (e.g., MM=month, mm=minutes, etc.).
Here's a suggested addition:
Common timestamp format specifiers: - YYYY: Year (e.g., 2024) - MM: Month (01-12) - DD: Day (01-31) - HH: Hour in 24h format (00-23) - mm: Minutes (00-59) - ss: Seconds (00-59) - SSS: Milliseconds (000-999)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/src/user-guide/format-struct-logs-syntax.md
(1 hunks)
🔇 Additional comments (1)
docs/src/user-guide/format-struct-logs-syntax.md (1)
83-83
: The format specifier correction looks good, eh!The change from
MM
(months) tomm
(minutes) in the timestamp format string is correct and matches the expected behaviour for time formatting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the PR title, how about
fix(docs): Correct minute format specifier in example format string (fixes #164).
Sure. Mind if I use "minutes"? "minute" technically has two meanings (a period of time or something small). |
sure |
Description
As #164 describes, in the docs, the example format string uses the wrong format specifier for minutes (the issue says months, but means minutes). This PR fixes the doc.
Validation performed
Validated that opening the following file in the log viewer, and formatting it with the format string in the example showed the minutes of the second log as
59
(✅) rather than12
(❌).Summary by CodeRabbit
MM
to lowercasemm