Release/0.1 #1
Merged
Release/0.1 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- load data model DDL from setup script instead from test suite
- move setup/teardown script to more shallow level since they not only supper DB tests - adjust require paths accordingly - provide global DB config json - remove obsolete testDbConfig.json
- include dependencies and define script entry points - add main service module app.js - add test suite for basic REST GET - adapt DB returned data structure via breaking a POINT into coordinates
- extract procedure for preparing DB model into a separate module
- which is used as spec
- including dedicated dbTest
- BTW correct mistakenly shutting down the pool and apply client.release - introduce queryParser - add dedicated serviceTest
- BTW include a README file describing what's there
- adjust test case accordingly - update package.json test command for better explicitness
- also add a further error guard in weatherApi.js to address a corner case
- and update service test acoordingly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge release/0.1 back to master