XWIKI-23790: Search facets numbers background are displayed elongated downwards when the filter name is on two lines #4908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… downwards when the filter name is on two lines * Fixed the error in style on L862. * Updated the SSX to use CSS variables instead of colibri colortheme ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-23790
Changes
Description
Clarifications
colorThemeMappingOutput.vmto figure out what variable contained the same value. Except for colibri colortheme level customizations, this should have no impact on the final style.Screenshots & Video
After the PR is updated, we can see that the entry count pill on the right doesn't extend vertically when there's space:
The screenshot also highlights that the workaround found to avoid the YUI compressor messing the CSS compilation works.
Executed Tests
Manual tests on my local instance.
I successfully built quality tests:
mvn clean install -f xwiki-platform-core/xwiki-platform-search/xwiki-platform-search-solr/xwiki-platform-search-solr-ui -Pquality.I did not run any docker tests because this is a minor style only change.
Expected merging strategy