JIRA-70: The Jira macro inserts a paragraph when used in inline mode #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmassol
reviewed
Apr 1, 2025
| @@ -113,6 +113,7 @@ protected Block execute(boolean async, boolean cached) | |||
| this.asyncContext.useEntity(this.sourceReference); | |||
| } | |||
| try { | |||
| this.context.setInline(this.inline); | |||
There was a problem hiding this comment.
I feel this would need some explanation as I'm not sure I understand the need for this line since at
It feels more like the context is modified somehow somewhere and maybe might need some cloning, but idk, I haven't analysed the problem.
There was a problem hiding this comment.
There was a problem hiding this comment.
This seems wrong to me. This is updating the context that is shared with other macros that are currently executed in the main thread and would thus influence the inline state of other currently executed macros.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.xwiki.org/browse/JIRA-70
This issue reproduces when executed inside macros such as
versionandputfootnote.In these cases, the MacroTransformationContext stored in the async renderer macro is updated before the asynchronous call of the jira macro. The inline property is updated to
true.