Skip to content

Conversation

@ClementEXWiki
Copy link
Contributor

Jira URL

https://jira.xwiki.org/browse/CRISTAL-675

Changes

Description

  • The "syncing changes" message now only appears after 1 full second, to avoid flashing
  • Before that full second, nothing appears on the screen

Clarifications

N/A

Screenshots & Video

N/A

Executed Tests

N/A

Expected merging strategy

  • Prefers squash: Yes
  • Backport on branches:
    • N/A

Copy link
Contributor

@manuelleduc manuelleduc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks ok but now that blocknote-react has been moved to xwiki-platform, the fix must be applied there.
Off the top of my head, you need to:

  1. move https://jira.xwiki.org/browse/CRISTAL-675 to XWIKI (you can do this from Jira's UI)
  2. create a PR on https://github.com/xwiki/xwiki-platform/ with the new Jira ID

Let me know if you need more details.
Also, I'm still working on making it easy to test cristal with the most recent xwiki-platform npm packages, so let me know if you need help with that.

@ClementEXWiki
Copy link
Contributor Author

New PR at: xwiki/xwiki-platform#4901

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants