fix(http): reap idle TCP tunnels to bound goroutine and fd growth - #405
Open
Okdusty wants to merge 1 commit into
Open
fix(http): reap idle TCP tunnels to bound goroutine and fd growth#405Okdusty wants to merge 1 commit into
Okdusty wants to merge 1 commit into
Conversation
Established TCP tunnels blocked on reads with no deadline, so a peer that vanished without a FIN/RST left both copy goroutines and both fds alive forever. Under a busy client they accumulated over long uptime and drove CPU up (observed ~264% average after ~15h uptime; ~1% on a fresh process). Wrap the tunnel conns in the existing IdleTimeoutConn, as the UDP path already does, so a fully-silent tunnel is reaped after DefaultTunnelIdleTimeout (300s). Activity in either direction resets the timer, so active transfers are unaffected, and the resulting timeout is already treated as a benign tunnel close.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Established TCP tunnels blocked on reads with no deadline, so a peer that vanished without a FIN/RST left both copy goroutines and both fds alive forever. Under a busy client they accumulated over long uptime and drove CPU up (observed ~264% average after ~15h uptime; ~1% on a fresh process).
Wrap the tunnel conns in the existing IdleTimeoutConn, as the UDP path already does, so a fully-silent tunnel is reaped after DefaultTunnelIdleTimeout (300s). Activity in either direction resets the timer, so active transfers are unaffected, and the resulting timeout is already treated as a benign tunnel close.