Enable using ligatures addon outside electron

[LabhanshAgrawal]

Based on the discussion from #958
To test this in the demo make sure to enable #font-access in chrome://flags
And then set some font with ligatures
Creating as draft right now as I still need to look a bit into the webpack stuff.

[Tyriar]

This didn't seem to work for me with Fira Code and any of the 3 renderers (I think only dom and maybe canvas works with ligatures atm?). Any hints to get it to work? I enabled the chrome flag.

[LabhanshAgrawal]

After checking this out you'd have to do a yarn install at the root as there's an update to the dependencies. (In case you haven't done this already)

Also, I guess I need to look into the tests.

[LabhanshAgrawal]

Also, you'd need to relaunch chrome after changing the flag. (I don't remember if it asks for relaunch itself)
Are you getting any error on the console?

[LabhanshAgrawal]

@Tyriar did it work for you?

[Tyriar]

There was an error in console:

SecurityError User activation is required.

No prompt though.

I tried disabling ligatures by default so I can check the box and then I get this:

Clicking allow didn't work though, even after reloading and trying again.

[Tyriar]

[Tyriar]

Oh actually, it does work after that and setting the font. The prompt is a bit of a pain though that it needs user action 🤔

[Tyriar]

😍

[LabhanshAgrawal]

Will add the comments as you mentioned.
Expect a bit slow progress on the tests and webpack stuff though, as I'm caught up in a lot of work recently.
Great to see that I didn't have to use It works on my machine™️ 😜

[LabhanshAgrawal]

The prompt doesn't come after the first time AFAIK so that should be ok.

[Tyriar]

The prompt doesn't come after the first time AFAIK so that should be ok.

Yep, we'd want to keep it off by default and call this out in the readme though that it may cause a permissions prompt and will require to be hooked up to a "user event".

[Tyriar]

The tests hang because loading the font fails

Error: navigator is not defined

Fixing...

[Tyriar]

Thanks for the hard word 🙂

[LabhanshAgrawal]

Thanks for resolving the tests and merging it 😊.
I hope this will help speed up development on the ligatures addon.
Cheers