xterm test cases #161
Merged
xterm test cases #161
+3,863
−257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,73 @@ | |||
| from glob import glob | |||
There was a problem hiding this comment.
Ah well with this file I created the expected xterm outputs. It sits there just in case some test case is faulty or needs some adjustments and a rebuild of xterm output. Since it is in Python it can be deleted (you can also get the xterm output with shell tools).
There was a problem hiding this comment.
Let's remove this file then, since it is not being used directly by this repository, in order to keep the codebase lean 😊 .
|
Hi @jerch thanks a lot for this contribution! I made some comments at first, after resolving I will dig deeper into this. |
|
@jerch thanks a lot for the last patch! Could you please also rebase with master and resolve conflicts? Then we can merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding xterm conformance tests. See #156.
I fixed most of the test case input files (up to test 44), any higher test needs to be checked before using. I also switched off all failing test cases for now.
If you are going to apply the test cases please also give the original author of the input files the appropriate credits (https://github.com/MarkLodato).