Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix charset drawing #1566

Merged
merged 1 commit into from
Jul 12, 2018
Merged

Fix charset drawing #1566

merged 1 commit into from
Jul 12, 2018

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Jul 12, 2018

Fixes #1565

// FIXME: Should code be replaced as well?

😅

@Tyriar Tyriar added this to the 3.5.1 milestone Jul 12, 2018
@Tyriar Tyriar self-assigned this Jul 12, 2018
@mofux
Copy link
Contributor

mofux commented Jul 12, 2018

LGTM 👍

@Tyriar Tyriar merged commit b84dba2 into xtermjs:master Jul 12, 2018
@Tyriar Tyriar deleted the 1565_charset_fix branch July 12, 2018 15:46
@Tyriar
Copy link
Member Author

Tyriar commented Jul 12, 2018

Cherry picked to release/3.5

ghost
ghost reviewed Oct 13, 2018
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ #1753

@Tyriar
Copy link
Member Author

Tyriar commented Oct 15, 2018

@Martinpj89 ?

/cc @jerch

@renovate renovate bot mentioned this pull request Nov 15, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
3.5.1
Development

Successfully merging this pull request may close these issues.
2 participants
@Tyriar @mofux