-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a fallback DOM renderer #1432
Merged
Merged
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
16393b2
Initial DOM renderer implementation
Tyriar 20ff107
Call IRenderer.onCharSizeChanged at right time
Tyriar 58ce5e2
Only update dimensions when char size changes
Tyriar 3cab8be
Merge branch 'oncharsizechanged' into 1360_dom_renderer
Tyriar 418f2c6
Fix row height, add cursor
Tyriar 1d2f356
Add a bunch of constants
Tyriar d777513
Handle focus, emit refresh
Tyriar e9f4d39
Start on selection
Tyriar e3e4dcb
Support selection
Tyriar 2c39493
Update after a options change
Tyriar b14308f
Resolve a bunch of TODOs
Tyriar 6cadd7c
Fill in documentation on new option
Tyriar 52e71a2
Support italic
Tyriar 09624c1
Move standard width to style element
Tyriar 5b5eb48
Polish
Tyriar cd3eea5
Improve typings
Tyriar 2f618b3
Merge branch 'master' into 1360_dom_renderer
Tyriar f055e0e
Throw exception for unrecognized renderer type
Tyriar aa1e1c5
Scope styles per terminal
Tyriar 6024e7c
Size row container so scroll bar shows
Tyriar 2b4c5ad
Set font family and size
Tyriar 1736c1e
Prevent outside line-height styles from affecting cursor
Tyriar 85dada2
Merge remote-tracking branch 'origin/master' into 1360_dom_renderer
Tyriar 2097527
Merge remote-tracking branch 'ups/master' into 1360_dom_renderer
Tyriar c2b5a24
Refactor and add some tests to dom renderer
Tyriar 82fdcc0
Get DomRendererRowFactory test coverage to 100%
Tyriar 52be558
Merge branch 'master' into 1360_dom_renderer
Tyriar 1ca6e51
Fix lint
Tyriar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe you can add an open option to provide custom renderers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mofux and I will be improving how renderers attach soon, the DOM renderer will eventually be moved to an addon. Also I'm not sure about swapping out the renderer in its entirety in the API but I definitely want people to contribute layers that could sit on top.