A few small fixes in GUI and Providers #1861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix providers: - Liaobots - Fixed system message changed from "You are ChatGPT, a large language model trained by OpenAI. Follow the user's instructions carefully." to "You are a helpful assistant." Providers added: - Feedough - Added a new provider with GPT-3 model - Cnote - Added a new provider with GPT-3.5 model
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello! Here's my review for the pull request titled "A few small fixes in GUI and Providers":
Review by g4f Copilot:
Thank you for your contribution to the project! It's great to see community engagement and efforts to improve the codebase. Here are my observations:
-
GUI Changes:
- The update in
index.htmlto correct the model value fromllama2-70btollama3-70b-instructis a necessary fix for accuracy in the dropdown. Good catch!
- The update in
-
Provider Updates:
- In
Llama.py, the renaming of models to include-instructsuffix aligns with the naming convention and clarifies the model's purpose. This change enhances readability and consistency. - The modifications in
PerplexityLabs.pyseem to streamline the list of models and remove duplicates. It's important to ensure that all referenced models are still accessible and functional after these changes.
- In
-
Code Consistency:
- The diff shows a consistent approach to naming and structuring, which is beneficial for maintaining the code.
-
Error Handling:
- The change in the exception message to include the
messagevariable inPerplexityLabs.pyis a minor but helpful improvement for debugging.
- The change in the exception message to include the
Overall, the pull request introduces small but meaningful improvements that contribute to the project's health. I recommend verifying the availability of all models after the changes to ensure no functionality is lost.
Once again, thank you for your work on this. It's always appreciated when individuals take the time to refine and enhance our projects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed.
GUI:
- index.html
Providers:
- Llama.py
- PerplexityLabs.py