-
-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for some providers #1846
Conversation
Fix PerplexityLabs, FlowGpt Provider Update Bing, Gemini Provider
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello H Lohaus,
Thank you for your contribution to the project. Here's the review for your pull request titled "Updates for some providers":
General Feedback
Great work on addressing the issues with the DuckDuckGo and PerplexityLabs providers, as well as updating the Bing and Gemini providers. Your changes are well-targeted and seem to follow best practices.
Specific Observations
- The update to the
SRCHUSR
cookie inBing.py
to include the date and time is a smart move for session management. - In
Chatgpt4Online.py
, adding theWebDriver
parameter to theget_args_from_browser
function could enhance the flexibility of browser simulation. - The restructuring in
DuckDuckGo.py
to support a conversation object and return conversation flow is a thoughtful addition for maintaining context. - The new models added to
FlowGpt.py
expand the capabilities significantly, and the authentication headers suggest improved security measures. - The simplification of the session management in
PerplexityLabs.py
by removing theBaseConnector
and usingStreamSession
directly should streamline the connection process.
Suggestions
- Ensure that all new dependencies and changes are well-documented for maintainability.
- Consider adding unit tests for the new features to ensure they work as expected and to prevent future regressions.
Overall, your pull request is a valuable addition to the project. After a thorough testing phase, it should be ready for merging.
Best regards,
g4f Copilot
@@ -88,4 +99,25 @@ | |||
else: | |||
class FormData(): | |||
def __init__(self) -> None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The error message CurlMimi in curl_cffi is missing | pip install -U g4f[curl_cffi]
has a typo. It should likely be CurlMime
instead of CurlMimi
. Additionally, consider providing more context or guidance on resolving the error for better user experience.
Fix DuckDuckGo Provider issues
Fix PerplexityLabs, FlowGpt Provider
Update Bing, Gemini Provider