Feature/dataframe protocol#87
Closed
RohanDisa wants to merge 11 commits into
Closed
Conversation
- Convert df_test.py from unittest to pytest with fixtures and markers - Convert df_integrationtest.py to pytest format with integration markers - Update sql_test.py with pytest fixtures and modern assertions - Add pytest configuration to pyproject.toml - Format all test files with pyink - Add @pytest.mark.unit, @pytest.mark.integration, @pytest.mark.gcs markers - Maintain existing project structure and Google-style docstrings Tests now use modern pytest features while respecting project guidelines.
- Assumed tests to be default unit tests, so removed explicit markers. - Omitted classes for a cleaner, more readable structure. - Added all missing test cases that were previously skipped in df_test. - Moved all fixtures to the top for better organization. - Reverted to the original project.toml, which is sufficient for running tests.
Co-authored-by: Alex Merose <alex@openathena.ai> Signed-off-by: Rohan Disa <105740583+RohanDisa@users.noreply.github.com>
…e pytest markers.
Signed-off-by: Rohan Disa <105740583+RohanDisa@users.noreply.github.com>
- Update CI configuration to exclude integration tests - Fix code formatting with pyink - All unit tests now passing (25/26 tests pass, 1 skipped)
…ial XarrayBuffer Set up the dataframe interchange protocol scaffolding based on earlier guidance and implemented the initial XarrayBuffer component. Introduced a dedicated xarray_sql.dataframe_protocol subpackage so protocol-specific logic has its own organized namespace rather than crowding existing modules. Open to restructuring this if you prefer the classes to live directly under the main package. Currently placed both the abstract Buffer interface and the concrete XarrayBuffer implementation in core.py; happy to split these into separate files if that aligns better with the project structure. Once the layout is settled, I’ll proceed with implementing the remaining two protocol classes as discussed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.