Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jossversion #68

Merged
merged 7 commits into from
Dec 19, 2024
Merged

Jossversion #68

merged 7 commits into from
Dec 19, 2024

Conversation

drannawatts
Copy link
Member

Lots of small changes for the intended JOSS release (which will be v2.1.0).

I've bundled all changes since the last release in the CHANGELOG, made small changes to simplify the publications page, updated copyright year because I am too lazy to do this again on Jan 1, and tried to catch all of the v2.0.0 -> v2.1.0 changes needed. Please check carefully that I have caught all of them!

@drannawatts drannawatts requested a review from nr1118 December 18, 2024 15:07
@thjsal
Copy link
Contributor

thjsal commented Dec 18, 2024

I think you should update the version numbers in neost/__init__.py and in docs/source/conf.py.

Caught by Lucien doing one of his practice NEoST runs!
Nathan to add to CHANGELOG on Thurs!
@nr1118
Copy link
Collaborator

nr1118 commented Dec 18, 2024

I also will modify the CHANGELOG on Thursday to account for the minor fix caught by Lucien when doing one of his practice runs!

@drannawatts
Copy link
Member Author

Yikes, conf.py still has v1.0.0! That's why my search didn't find it :-D Will fix now, and the other file, thanks @thjsal !

@drannawatts
Copy link
Member Author

And __init.py was still on v 0.10.0...... [screams in versioning]

Changed language to include future versions of NEoST and this feature
Copy link
Collaborator

@nr1118 nr1118 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good! I have also did the minor fix that I had to make yesterday in regard to Lucien's issue and put it in the CHANGELOG. Oh and I changed one of the comments in PosteriorAnalysis.py to include future versions of NEoST since it references v2.0.0

@nr1118 nr1118 merged commit 787b516 into main Dec 19, 2024
5 checks passed
@drannawatts drannawatts deleted the jossversion branch December 20, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants