Documentation updates to include the Cython versus Python speed-up #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Included approximate computational speed-ups from using Cython over Python. This was done by using %timeit -r 10 magic function to compute approximate run times.
drannawatts
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did this comparing Cython and Python using the %timeit magic function when sampling 100 EoSs and computing their corresponding log-likelihoods 10 times over. Here I found that for the TOVdm vs TOVdm_python the speed-up is about 15x and for TOVr vs TOVr_python the speed-up is about 20x. This difference is because the TOVdm/TOVdm_python solvers have to compute the adm_fraction is slows both codes down.