Do not yield output, the AsyncServer API does not expect any value

...but it might, see xp-framework/networking#28
xp-forge · Dec 3, 2023 · 3e8c701 · 3e8c701
1 parent 968b8de
commit 3e8c701
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/main/php/web/handler/FilesFrom.class.php b/src/main/php/web/handler/FilesFrom.class.php
@@ -77,7 +77,7 @@ private function copy($out, $file, $range) {
 
     $length= $range->length();
     while ($length && $chunk= $file->read(min(self::CHUNKSIZE, $length))) {
-      yield 'write' => $out;
+      yield 'write' => null;
       $out->write($chunk);
       $length-= strlen($chunk);
     }
@@ -129,7 +129,7 @@ public function serve($request, $response, $target, $mimeType= null) {
         $file->open(File::READ);
         try {
           do {
-            yield 'write' => $out;
+            yield 'write' => null;
             $out->write($file->read(self::CHUNKSIZE));
           } while (!$file->eof());
         } finally {