X2-4379: Add option to not select future dates in pre-calculated date ranges #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemanjakrstic
suggested changes
Jan 9, 2023
Comment on lines
+91
to
+99
| const newRange = { ...range }; | ||
| if ( | ||
| !shouldSelectFutureDatesInRelativeRange && // don't select future dates, e.g. for cash flow report | ||
| range.to.isAfter(dayjs().get("date")) | ||
| ) { | ||
| newRange.to = dayjs().get("date"); | ||
| } | ||
|
|
||
| onChange(newRange, modifiers, null); |
There was a problem hiding this comment.
I think this will not work. Did you mean to use dayjs().toDate() instead of dayjs().get("date")?
dayjs().get("date") just returns a number of the current day in month.
There was a problem hiding this comment.
Also, I feel like this logic belongs to x2-seller and not ui-kit. We can discuss when you are free
There was a problem hiding this comment.
Yeah needs to be changed, not sure how it was working when I checked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.