fast: Use Web crypto #1045
Merged
fast: Use Web crypto #1045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonnyp
reviewed
Jan 6, 2025
Comment on lines
+102
to
-107
| const streamFeatures = await getStreamFeatures({ element, features }); | ||
| const fast_available = !!fast?.mechanism; | ||
|
|
||
| if (mechanisms.length === 0 && !fast_available) { | ||
| throw new SASLError("SASL: No compatible mechanism available."); | ||
| } | ||
|
|
||
| const streamFeatures = await getStreamFeatures({ element, features }); | ||
| const fast_available = !!fast?.mechanism; |
There was a problem hiding this comment.
In which scenario would a token be available but no compatible sasl mechanism?
There was a problem hiding this comment.
We've been discussing doing FAST-only (where the inital token is provisioned out of band / during registration) for some accounts, so that would be an example in the real world of this.
sonnyp
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch SASL mechanism used by FAST over to web crypto for smaller bundle size