Implement SASL2, BIND2, and FAST #1006
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -263,6 +263,9 @@ class Connection extends EventEmitter { | |||||||
| this.socket.secure() && | ||||||||
| (this.streamFrom || this.jid) | ||||||||
| ) { | ||||||||
| // When the stream is secure there is no leak to setting the stream from | ||||||||
|
There was a problem hiding this comment.
Needs clarification and a reference to the spec 🙏 There was a problem hiding this comment. What kind of clarification would you like for that? There was a problem hiding this comment. Spec reference:
|
||||||||
| // This is suggested in general and in required for FAST implementations | ||||||||
| // in particular | ||||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||||
| headerElement.attrs.from = (this.streamFrom || this.jid).toString(); | ||||||||
| } | ||||||||
| headerElement.attrs["xml:lang"] = lang; | ||||||||
|
|
||||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need a new
streamFromparam?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because we want to set the from on initial connection, before the jid is otherwise known in a c2s case, so it must be provided by the caller. Setting the jid too early causes various parts of the library to assume we have done binding already since that is where that value comes from curretly.