RDKBDEV-3295: Adding configuration for new labels "webpa-interface-la… #470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
shashwats1
force-pushed
the
master
branch
3 times, most recently
from
d6d1279 to
2aa3e76
Compare
|
Internal ticket for tracking https://ccp.sys.comcast.net/browse/RDKCOM-5455 |
sadhyama
requested changes
Oct 10, 2025
Contributor
There was a problem hiding this comment.
Change looks good to me.
Please add the 2 new fields in parodus README file and its usage similar to existing command line arguments.
Github work flow builds are not running due to ubuntu 20 deprecation, we are planning to fix this as a separate bug.
So once changes are done , will merge PR as it is already unit tested.
shashwats1
force-pushed
the
master
branch
2 times, most recently
from
dc45285 to
b0fa359
Compare
…bel" and "wan-ipv4-address" in webpa convey header. DESCRIPTION: Added configurations for the labels mentioned, "webpa-interface-label" can be configured with "Fixed" or "Mobile" values for representing primary or backup WAN respectively. "wan-ipv4-address" can represent the ipv4 address of the current active interface like ipv4 address of erouter0 interface. TESTING DONE: Test results captured in RDKBDEV-3295 Signed-off-by: shashwats1 <[email protected]>
Author
|
Addressed the review comment and updated the README file |
sadhyama
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RDKBDEV-3295: Adding configuration for new labels "webpa-interface-label" and "wan-ipv4-address" in webpa convey header.
DESCRIPTION: Added configurations for the labels mentioned, "webpa-interface-label" can be configured with "Fixed" or "Mobile" values for representing primary or backup WAN respectively. "wan-ipv4-address" can represent the ipv4 address of the current active interface like ipv4 address of erouter0 interface.
TESTING DONE: Test results captured in RDKBDEV-3295