Skip to content

Conversation

GalvinGao
Copy link
Contributor

Fix LINE SDK URL handling in iOS AppDelegate

🔄 Type of change:

  • ✨Feature/chore
  • ♻️ Refactor
  • 🔧 Bugfixes

✏️ Description:

Fixed the URL handling in iOS AppDelegate for LINE SDK integration. Previously, the implementation would return immediately after calling the LINE SDK handler, preventing other URL handlers from processing URLs that LINE SDK didn't handle. Updated both Swift and Objective-C implementations to only return true/YES when the LINE SDK actually handles the URL.

@KazukiTanaka
Copy link

@GalvinGao Thanks for this thoughtful fix!

I was running into the exact same issue where the LINE SDK's URL handling was blocking other URL handlers from processing their URLs. The previous implementation would return immediately after calling LineLogin, which prevented the URL handling chain from continuing.

Your solution to check the return value and only return true/YES when LINE SDK actually handles the URL is perfect - it allows other handlers to process URLs that LINE doesn't recognize.

This fix resolves a real compatibility issue for apps using multiple URL handlers. Much appreciated! 🚀

image

@Joaguirrem Joaguirrem merged commit d495175 into xmartlabs:main Sep 29, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants