Skip to content

Conversation

@apocelipes
Copy link
Contributor

@apocelipes apocelipes commented Dec 10, 2025

Fixes #8783
Fixes #8453
Fixes #7879

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @apocelipes, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the lsp-framework package definition to ensure its build process is robust and compatible with newer environments. It introduces support for a new version of the framework and refines the pre-build checks to enforce specific toolchain and operating system requirements for Windows ARM64 and macOS platforms, addressing potential build issues and improving overall stability.

Highlights

  • New Version Support: Added support for version 1.3.0 of the lsp-framework, including its specific SHA hash.
  • Link Dependency: Introduced a new link dependency on 'lsp' for the framework.
  • Enhanced Build Checks: Refactored the on_check function to include more robust platform-specific validations. This now explicitly checks for Visual Studio 2022 or later for Windows ARM64 targets and enforces a minimum macOS version of 15 for macOS builds.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the lsp-framework package by adding version 1.3.0 and introducing build-time checks for Windows ARM64 and macOS. The changes are reasonable and help fix build issues on these platforms. My review includes one suggestion to remove an unused module import in packages/l/lsp-framework/xmake.lua to improve code quality.

@waruqi waruqi merged commit 52a81f7 into xmake-io:dev Dec 10, 2025
61 checks passed
@apocelipes apocelipes deleted the fix-lsp branch December 11, 2025 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants