Skip to content

Auto-update lsp-framework to 1.3.0 #8783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
waruqi wants to merge 1 commit into from
Closed

Auto-update lsp-framework to 1.3.0 #8783

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/l/lsp-framework/xmake.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ package("lsp-framework")
add_urls("https://github.com/leon-bckl/lsp-framework/archive/refs/tags/$(version).tar.gz",
"https://github.com/leon-bckl/lsp-framework.git")

add_versions("1.3.0", "b6b4c0cad392b5e6b5b3897095199ed1b9217b7e468d61993eb4e091972c264b")
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

While this correctly adds the new version, the existing patches for version 1.0.1 are not applied to 1.3.0. My analysis of the upstream repository for version 1.3.0 shows that the issues addressed by these patches (missing installation rules and a missing header include) are still present. This will cause the build to fail for version 1.3.0.

To fix this, the version constraints for the patches need to be updated to include 1.3.0. You should change the patch applications to be something like this:

    add_patches(">=1.0.1", "patches/1.0.1/fix-install.diff", "bb5e4436091ba1846144ffa80fb8afd4d0213760bce45dd6fd31662905cb4bc3")
    add_patches(">=1.0.1", "patches/1.0.1/fix-missing-ios.diff", "8447605c2ed14cfbf394b29ffe2348e2179424504100aa01cd88b3d054e5ceb1")

This will ensure the necessary fixes are applied to all versions from 1.0.1 onwards, including the new 1.3.0.

add_versions("1.0.1", "07f924d851896a2d424d554d20820483f8458aa1ff907bb68657b0d2d0bd0d13")

add_patches("1.0.1", "patches/1.0.1/fix-install.diff", "bb5e4436091ba1846144ffa80fb8afd4d0213760bce45dd6fd31662905cb4bc3")
Expand Down
Loading