glslang: improve dependence handling

[Willaaaaaaa]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @Willaaaaaaa, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the glslang package's xmake.lua script to introduce more fine-grained control over its build configurations and external dependencies. The primary goal is to make the integration of SPIRV-Tools and HLSL support conditional, allowing users to enable or disable these features based on their specific project requirements. This change improves the modularity and flexibility of the glslang build, potentially reducing unnecessary dependencies and build times.

Highlights

• Conditional SPIRV-Tools Integration: The build process for glslang now includes a new spirv_tools configuration option. When enabled, this option dynamically adds SPIRV-Tools and its associated python 3.x dependency, and applies the necessary CMake modifications for linking. This allows for a more modular build, only including these components when explicitly desired.
• Configurable HLSL Support: A new hlsl configuration option has been introduced, defaulting to true. This option now explicitly controls whether HLSL support is enabled during the glslang build, including the conditional linking of the HLSL library, providing greater control over the final build output.
• Refined CMake Build Flags: Several CMake build flags have been added or made conditional to enhance build flexibility. This includes adding -DGLSLANG_TESTS=OFF and -DENABLE_PCH=OFF, and making the -DENABLE_OPT flag conditional on the spirv_tools configuration, ensuring a more tailored build process.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request improves the dependency handling for the glslang package by making spirv-tools and HLSL support optional, controlled by configuration flags. This is a solid improvement for modularity and configurability. The implementation correctly uses conditional logic to manage dependencies, build file modifications, and CMake options based on the selected configuration. I've identified one area concerning library linking logic that could be improved to prevent potential linking errors under specific configurations and have provided a detailed suggestion for it.