Skip to content

Conversation

star-hengxing
Copy link
Contributor

No description provided.

Copy link

Summary of Changes

Hello @star-hengxing, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the flexibility of the gtest package by integrating CMake as an alternative build system. This change allows users to leverage CMake for building gtest, providing more options for dependency management and build customization, while maintaining compatibility with the existing xmake-driven build process. The primary impact is offering a choice in how gtest is compiled and installed within the xmake ecosystem.

Highlights

  • New Build System Option: Introduced a new configuration option, cmake, for the gtest package, allowing users to explicitly choose between xmake's native build system and CMake for building gtest.
  • Conditional CMake Dependency: Added a conditional dependency on the cmake package, which is automatically included if the cmake build system option is enabled for gtest.
  • Flexible Installation Logic: Modified the on_install function to dynamically switch between CMake-based installation and the existing xmake-based build process, depending on the cmake configuration. This includes passing relevant build parameters like build type, shared library status, and gmock support to CMake.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces CMake support for the gtest package, making it the default build method. This is a positive change that aligns the package with gtest's official build system. The implementation is largely correct, adding the necessary CMake dependency and configuring the build appropriately. However, there is a high-severity issue where the existing main configuration option is ignored in the new CMake build path, leading to inconsistent behavior. I've also included a medium-severity suggestion to improve code conciseness.

Comment on lines +45 to +51
if package:config("cmake") then
local configs = {}
table.insert(configs, "-DCMAKE_BUILD_TYPE=" .. (package:is_debug() and "Debug" or "Release"))
table.insert(configs, "-DBUILD_SHARED_LIBS=" .. (package:config("shared") and "ON" or "OFF"))
table.insert(configs, "-DBUILD_GMOCK=" .. (package:config("gmock") and "ON" or "OFF"))
import("package.tools.cmake").install(package, configs)
else

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The new CMake build path does not respect the main configuration option. In the xmake build path, package:config("main") controls whether the gtest_main target is a default part of the package. In this new CMake path, the main config is ignored, and gtest_main is always built but never becomes a default target. This is a behavioral regression that breaks configuration consistency for the package. Please ensure the main config is also handled in the CMake build path to maintain consistent behavior between the two build options.

@waruqi waruqi merged commit 925af21 into dev Sep 22, 2025
61 checks passed
@star-hengxing star-hengxing deleted the gtest branch September 22, 2025 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants