-
-
Notifications
You must be signed in to change notification settings - Fork 477
gtest: add cmake support #8157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gtest: add cmake support #8157
Conversation
Summary of ChangesHello @star-hengxing, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the flexibility of the gtest package by integrating CMake as an alternative build system. This change allows users to leverage CMake for building gtest, providing more options for dependency management and build customization, while maintaining compatibility with the existing xmake-driven build process. The primary impact is offering a choice in how gtest is compiled and installed within the xmake ecosystem. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces CMake support for the gtest package, making it the default build method. This is a positive change that aligns the package with gtest's official build system. The implementation is largely correct, adding the necessary CMake dependency and configuring the build appropriately. However, there is a high-severity issue where the existing main
configuration option is ignored in the new CMake build path, leading to inconsistent behavior. I've also included a medium-severity suggestion to improve code conciseness.
if package:config("cmake") then | ||
local configs = {} | ||
table.insert(configs, "-DCMAKE_BUILD_TYPE=" .. (package:is_debug() and "Debug" or "Release")) | ||
table.insert(configs, "-DBUILD_SHARED_LIBS=" .. (package:config("shared") and "ON" or "OFF")) | ||
table.insert(configs, "-DBUILD_GMOCK=" .. (package:config("gmock") and "ON" or "OFF")) | ||
import("package.tools.cmake").install(package, configs) | ||
else |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new CMake build path does not respect the main
configuration option. In the xmake
build path, package:config("main")
controls whether the gtest_main
target is a default part of the package. In this new CMake path, the main
config is ignored, and gtest_main
is always built but never becomes a default target. This is a behavioral regression that breaks configuration consistency for the package. Please ensure the main
config is also handled in the CMake build path to maintain consistent behavior between the two build options.
No description provided.