feat(chat): jump to a tab with Ctrl/Cmd+1-9 and reopen with Ctrl/Cmd+Shift+T - #502
feat(chat): jump to a tab with Ctrl/Cmd+1-9 and reopen with Ctrl/Cmd+Shift+T#502Adam-Dalloul wants to merge 2 commits into
Conversation
4e90a05 to
6c63693
Compare
6c63693 to
c5d16ca
Compare
|
Rebuilt on current main. The branch had drifted a long way behind, so this is now just its two commits cherry-picked onto main rather than a replay of everything in between. One thing worth your call before this lands. Your note on matchesDigitRowCode says the unshifted half of the positional fallback is latent because nothing binds digits 1-9. This PR binds all nine, so it stops being latent: on AZERTY, - sits on Digit6, so Ctrl+- matches mod+- by character and mod+6 by position, and one press would zoom out and jump to tab 6. Same shape for _ on Digit8. shortcutsConflict still cannot see it, for the reason you gave. I have not tried to fix it here since it is your design call which side should win. Happy to gate the positional fallback behind no other action matching by character, or to drop the fallback for digits other than 0, whichever you prefer. |
c5d16ca to
6945cfb
Compare
There was no numbered tab jump, only Ctrl/Cmd+Tab and Shift+Tab to cycle. There was also no way to get back a tab you just closed.
This adds the usual browser tab keys in the same always-mounted workspace controller as close/next/prev, so they still work when the tab strip is hidden.
Both bindings show up in Settings so they can be remapped.