-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Plasma Mobile to desktop-style-ids.txt #622
Conversation
Wouldn't a "chassis" property make more sense? (as defined in https://www.freedesktop.org/software/systemd/man/latest/org.freedesktop.hostname1.html#Semantics ) |
I agree introducing a chassis type, makes sense, but would not eliminate the need for plasma-mobile to be added. If you have chassis type desktop/mobile and plasma/plasma-mobile, you could still have Plasma on a desktop/laptop, Plasma on a tablet or convertible (which could prefer the mobile chassis for screenshots, but runs the Desktop Version of plasma), a plasma-mobile installation on a smartphone and plasma-mobile on a docked smartphone (which again would potentially prefer the desktop screenshots as long as you are in a "desktop/docked" mode. To identify all those four cases, one would need both attributes. I admit however that this is currently an edge case. Nevertheless plasma-mobile and plasma are two different desktop environments so ignoring the mentioned edge case it might make sense to add it anywhere. |
Ah so if it's a completely different environment it makes sense, I'm surprised to not see them in https://specifications.freedesktop.org/menu-spec/latest/apb.html though for instance |
I guess we should add |
I agree for phosh, however gnome-mobile is as far as I know "only" a WIP branch of GNOME which eventually aims to be completely upstreamed. (See the postmarketOS Wiki for details https://wiki.postmarketos.org/wiki/GNOME) so I would not add it to the list. Phosh and Plasma Mobile make sense to me, because they plan to stay separate environments from GNOME/KDE Plasma, while sharing certain components. Would you add Phosh to this MR or should I create another for it? |
Still, apps targeting gnome-mobile might have different screenshots (probably portait mode) and it would be useful to know that via metadata. That's why I thought it might be smart to add I think adding |
Maybe a fitting alternative here would be to add |
I think that would be bad as it probably breaks the possibility to have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also I agree with the others we should at least add phosh and probably also gnome mobile too, to that list :)
I do no longer just add stuff because it might be used in future, but only when it is specifically requested by the respective project owners / maintainers / contributors. |
Also, that C header is auto-generated, it doesn't need to be changed specifically as it will be regenerated at the next opportunity (but changing it also doesn't hurt in this case, so with respect to that, this patch is fine). |
Sorry for the noise, please don't add phosh and gnome mobile then Edit: To be clear, upon thinking this over - I don't think gnome mobile should be it's own platform. We probably don't want any screenshots, that actually include the shell or phosh shell. |
Co-authored-by: Carl Schwan <[email protected]>
Thanks for all the comments. I updated the PR with @CarlSchwan's suggestions and as mentioned by @ximion I won't add Phosh or GNOME Mobile for now. |
Nice! Let's merge it then! :-) |
As discussed in #611 this PR adds Plasma Mobile to the list of desktop style ids.
Let me know if anything is missing