meson: Pass -D_DARWIN_C_SOURCE on darwin #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh I just saw #556 (comment), give me a few sec to try... Update: Seems to work! |
This is probably a follow-up for 02ee2d0 ("fix macos build") and unbreaks the build on Nixpkgs x86_64-darwin, probably due to using even older SDKs? https://github.com/NixOS/nixpkgs/runs/19486840382 ``` > In file included from ../src/as-system-info.c:60: > In file included from /nix/store/51c1k4sj0irwgyvkgbyhqi0ggilyh3j2-Libsystem-1238.60.2/include/sys/sysctl.h:83: > /nix/store/51c1k4sj0irwgyvkgbyhqi0ggilyh3j2-Libsystem-1238.60.2/include/sys/ucred.h:91:2: error: unknown type name 'u_long' > u_long cr_ref; /* reference count */ > ^ > 1 error generated. > ninja: build stopped: subcommand failed. ``` Instead of adding another typedef, apply the suggestions on pull request 556 to pass `-D_DARWIN_C_SOURCE`, which seems to work fine for us too.
bobby285271
force-pushed
the
wip/bobby285271/macos-build
branch
from
cb7701e to
e0223cf
Compare
bobby285271
changed the title
|
Awesome, thanks for the patch! This feels like a much better solution than the previous type redefinitions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is probably a follow-up for 02ee2d0 ("fix macos build") and unbreaks the build on Nixpkgs x86_64-darwin. I don't know why, probably due to using even older SDKs? 🙃
https://github.com/NixOS/nixpkgs/runs/19486840382
https://logs.ofborg.org/?key=nixos/nixpkgs.273297&attempt_id=05115a28-17b2-4d53-b0e9-d6c2f6a02b63
Update: Instead of adding another typedef, apply the suggestions on pull request 556 to pass
-D_DARWIN_C_SOURCE, which seems to work fine for us too.