downloader: Check read bytes before appending to buffer

ximion · Jan 28, 2021 · 69c3eab · 69c3eab
1 parent bf4fe21
commit 69c3eab
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/src/asgen/downloader.d b/src/asgen/downloader.d
@@ -187,9 +187,8 @@ public:
         scope(exit) g_object_unref (stream);
 
         ptrdiff_t len;
+        ubyte[GENERIC_BUFFER_SIZE] buffer;
         do {
-            ubyte[GENERIC_BUFFER_SIZE] buffer;
-
             len = g_input_stream_read (stream, cast(void*)buffer.ptr, cast(size_t)buffer.length, null, null);
             if (len > 0)
                 dFile.rawWrite (buffer[0..len]);
@@ -206,11 +205,11 @@ public:
 
         auto result = appender!(ubyte[]);
         ptrdiff_t len;
+        ubyte[GENERIC_BUFFER_SIZE] buffer;
         do {
-            ubyte[GENERIC_BUFFER_SIZE] buffer;
-
             len = g_input_stream_read (stream, cast(void*)buffer.ptr, cast(size_t)buffer.length, null, null);
-            result ~= buffer[0..len];
+            if (len > 0)
+                result ~= buffer[0..len];
         } while (len > 0);
 
         return result.data;