Skip to content

fix(management): preserve callback forwarder reuse and cleanup generated artifacts#10

Merged
xiaojiou176 merged 5 commits intomainfrom
codex/closure-main-20260326
Mar 27, 2026
Merged

fix(management): preserve callback forwarder reuse and cleanup generated artifacts#10
xiaojiou176 merged 5 commits intomainfrom
codex/closure-main-20260326

Conversation

@xiaojiou176
Copy link
Copy Markdown
Owner

Repo closure salvage PR created during root workspace closure.\n\nIncluded commits:\n- chore(cleanup): stop tracking generated coverage and mock upstream artifacts\n- fix(management): reuse shared codex callback forwarder\n\nPurpose:\n- preserve effective local staged code safely under branch protection\n- move child repo closer to single-main clean baseline

Copilot AI review requested due to automatic review settings March 27, 2026 07:32
Copy link
Copy Markdown

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR cleans up generated artifacts from version control and updates the management OAuth callback forwarder to support safe reuse across concurrent WebUI auth sessions (instead of tearing down the listener per request).

Changes:

  • Add reference-counted reuse for the callback forwarder keyed by port/provider/target.
  • Add a management handler test covering shared forwarder lifecycle behavior.
  • Remove tracked coverage output artifacts from the repository.

Reviewed changes

Copilot reviewed 5 out of 7 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
internal/api/handlers/management/auth_files.go Add forwarder reuse + ref-counted lifecycle management for callback listener.
internal/api/handlers/management/auth_files_codex_webui_test.go Add test asserting forwarder reuse and that the listener remains until the last release.
coverage.audit.out Remove generated coverage artifact from tracking.
coverage-core-auth-proxy.out Remove generated coverage artifact from tracking.
coverage-amp-target.out Remove generated coverage artifact from tracking.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Collaborator

@terryyifeng terryyifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed with write access after forwarder lifecycle, cleanup, and race fixes. Approving pending green checks.

Copy link
Copy Markdown
Collaborator

@terryyifeng terryyifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed with fresh local verification: management package tests and race checks pass, doc gate is green, and the callback forwarder lifecycle issues have been addressed.

@xiaojiou176 xiaojiou176 merged commit c4fa816 into main Mar 27, 2026
6 checks passed
@xiaojiou176 xiaojiou176 deleted the codex/closure-main-20260326 branch March 27, 2026 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants