Open
Conversation
self.alive is an RPC call, which can take a long time (e.g. 45s) if there are problems with communicating to server. Previously the loop was being executed exactly timeout * 10 times befor timing out, resulting in 450s timeout instead of the requested value. Now it is executed only until current timestamp is larger or equal the pre-calculated expiration time.
mcdaniel67
reviewed
May 22, 2017
There was a problem hiding this comment.
Passing travis run rebased on top of my travis fix pr:
https://travis-ci.org/mcdaniel67/uiautomator/builds/234657095
| time.sleep(0.1) | ||
| timeout -= 0.1 | ||
| if not self.alive: | ||
| step_secs = 0.1 |
There was a problem hiding this comment.
What are your thoughts about making this a defaulted argument?
A doc string would be good on this method too.
|
|
||
| # Tests that start() timeout works correctly even in case communication | ||
| # with device takes too long. | ||
| def test_start_timeout_works_properly(self): |
There was a problem hiding this comment.
This test could be named better, particularly the "_works_properly" part. Maybe call it test_start_timeout_slow_device?
Also, any reason to go with comments over a docstring?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
self.alive is an RPC call, which can take a long time (e.g. 45s) if there are problems with communicating to server.
Previously the loop was being executed exactly timeout * 10 times before timing out, resulting in 450s timeout instead of the requested value.
Now it is executed only until current timestamp is larger or equal the pre-calculated expiration time.