fix(client): remove unneeded pub(in crate::r#mod) from Client::new #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't actually need this function to be public and it crashes rustc when compiling docs fixes xi-frontend#36
|
What is this syntax doing anyway? Looks like something that came with the 2018 edition? |
little-dude
approved these changes
Jul 21, 2019
|
See https://doc.rust-lang.org/reference/visibility-and-privacy.html. Basically make that function only visible in crate::mod (with r# because it's a raw identifier). |
|
Could we maybe make a new release? :) |
|
Sure. By the way, would you mind being a co-owner on crates.io? I usually work on my projects by bursts when I have a long period of free time and I'm not very responsive in between, so having a co-owner may be nice. |
|
Sure, being a co-owner would be great! Thanks for your efforts :) |
|
Just uploaded 0.0.8 and sent you an invite. |
|
Thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't actually need this function to be public and it crashes rustc when
compiling docs
fixes #36