Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rest grid model menu actions type #3392

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

leogretz2
Copy link
Contributor

@leogretz2 leogretz2 commented Jun 12, 2023

Hoist P/R Checklist

Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.

  • Caught up with develop branch as of last change.
  • Added CHANGELOG entry, or determined not required.
  • Reviewed for breaking changes, added breaking-change label + CHANGELOG if so.
  • Updated doc comments / prop-types, or determined not required.
  • Reviewed and tested on Mobile, or determined not required.
  • Created Toolbox branch / PR, or determined not required.

If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.

Pull request reviewers: when merging this P/R, please consider using a squash commit to
collapse multiple intermediate commits into a single commit representing the overall feature
change. This helps keep the commit log clean and easy to scan across releases. PRs containing a
single commit should be rebased when possible.

@leogretz2
Copy link
Contributor Author

Didn't change the types for similarly configured toolbarActions and formActions arrays in RestGridModel because using the separator with either of them is not supported.

@lbwexler
Copy link
Member

lbwexler commented Jun 12, 2023

Using the seperator with either of them is not supported'

Is that true? It looks to me like our toolbar code, actually handles '-' as a seperator. (It ought to handle '|' as the same, but that is another matter)

.map(it => (it === '-' ? toolbarSeparator() : it));

…p button (to account for buttonGroup) in that case instead of action button
@lbwexler
Copy link
Member

I like the symmetry here with all of the properties taking RecordActionLike -- its simpler for users to understand, even if they are less likely to use separators with their toolbar buttons than with menus.

The idea of extending the handling to | was just more of a speculation. I would not do it as part of this limited PR. I think if we decided it was a good synonym for - we could add it, but we would want to do that consistetnly throughout the toolkit.

@lbwexler
Copy link
Member

@jskupsik -- would like to discuss the requirement for the PR and see if we can get it merged, or abandon it.

Do Find it more than a little weird that we are passing a disabled button to represent this separator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants