-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rest grid model menu actions type #3392
base: develop
Are you sure you want to change the base?
Conversation
Didn't change the types for similarly configured toolbarActions and formActions arrays in RestGridModel because using the separator with either of them is not supported. |
Is that true? It looks to me like our toolbar code, actually handles '-' as a seperator. (It ought to handle '|' as the same, but that is another matter)
|
…p button (to account for buttonGroup) in that case instead of action button
I like the symmetry here with all of the properties taking RecordActionLike -- its simpler for users to understand, even if they are less likely to use separators with their toolbar buttons than with menus. The idea of extending the handling to |
@jskupsik -- would like to discuss the requirement for the PR and see if we can get it merged, or abandon it. Do Find it more than a little weird that we are passing a disabled button to represent this separator. |
Hoist P/R Checklist
Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.
develop
branch as of last change.breaking-change
label + CHANGELOG if so.If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.