Code

Dialog#1809

Code

Draft

lbwexler wants to merge 125 commits intodevelopxh/hoist-react:developfrom dialogXxh/hoist-react:dialogXCopy head branch name to clipboard

+1,838-543

Commits

Commits on Dec 26, 2019

• First cut of hoist dialog with isDraggable option.

  cnrudd

  committed
  471594f

• Removed unused imports.

  cnrudd

  committed
  7da244f

Commits on Dec 27, 2019

• Added canMaskClickClose prop and maskClick handler

  cnrudd

  committed
  2bab03f

• Fix maskclick handler

  cnrudd

  committed
  8a90e0f

• added todo

  cnrudd

  committed
  ec01ac3

Commits on Jan 2, 2020

• Support autoFocus: true on dialog children

  cnrudd

  committed
  73ccc65

Commits on Jan 3, 2020

• Replaced react-draggable with react-rnd, which uses react-draggable.

  cnrudd

  committed
  107c490

• Added --xh-dialog-box-shadow

  cnrudd

  committed
  90f5f42

• Support for resizing

  cnrudd

  committed
  d6650a3

Commits on Jan 6, 2020

• Fix repaint bug

  cnrudd

  committed
  9a7f05b

• Remove redundant use of splitLayoutProps

  cnrudd

  committed
  b3fe561

• Remove bug comment and fix. Bug existed only on chrome 78.3x . Upgrading to chrome v79 fixed the issue.

  cnrudd

  committed
  2a65a78

• Refactored with elementfactory.

  cnrudd

  committed
  c8f401b

• Remove need for constructor.

  cnrudd

  committed
  8e347e3

Commits on Jan 7, 2020

• Converted Dialog from class comp to function comp.

  cnrudd

  committed
  3af10ed

• Support resizable config

  cnrudd

  committed
  a3b640b

• Refactor, with dialogHeader impl

  cnrudd

  committed
  d583d76

Commits on Jan 8, 2020

• Linting.

  cnrudd

  committed
  fad1660

• Let dialogs autocenter based on content dimensions;

  Show description for 88b0d45
  cnrudd

  committed
  88b0d45

Commits on Jan 14, 2020

• Use given width and height props if resizeable

  cnrudd

  committed
  c06514e

• throw if no dims props with resizable = true

  cnrudd

  committed
  42a4d00

• Add Maximize Minimize toggle if resizable.

  cnrudd

  committed
  d7d7a10

Commits on Jan 17, 2020

• Implemented localstorage statemodel on dialog.

  cnrudd

  committed
  41c129c

• Improve handling of 0 position values.

  cnrudd

  committed
  cfaa2af

Commits on Jan 18, 2020

• Improve safe state loading on dialog.

  cnrudd

  committed
  e3169c1

• Remove unnecessary setting of defaults on RnD, fix unMaximize.

  cnrudd

  committed
  1d57410

• Support x, y props.

  cnrudd

  committed
  21f9f5d

Commits on Jan 21, 2020

• Merge branch 'develop' into hoistDialog

  cnrudd

  committed
  10f08c2

• Merge branch 'develop' into hoistDialog

  cnrudd

  committed
  40c27b5

Commits on Jan 23, 2020

• Cleanup setState on render logic

  cnrudd

  committed
  28c1175

Commits on Feb 2, 2020

• Unifiied dialog sub component with mask and closeOnOutsideClick props.

  cnrudd

  committed
  ffb7b14

Commits on Feb 9, 2020

• added --xh-dialog-box-shadow

  cnrudd

  authored
  f320af6

• Support style passthrough and zIndex prop

  cnrudd

  committed
  34475a7

• Merge branch 'hoistDialog' of github.com:exhi/hoist-react into hoistDialog

  cnrudd

  committed
  07fb4bb

• --xh-dialog-box-shadow dark theme

  cnrudd

  authored
  4c38c76

Commits on Feb 10, 2020

• Improve takeup of style & zIndex & rndoptions

  cnrudd

  committed
  321de51

Commits on Feb 15, 2020

• Cleanup prop and model passing.

  cnrudd

  committed
  2f934ec

• Remove unused zIndex

  cnrudd

  committed
  cf7e6c4

• Support static base zindex for all dialogs

  cnrudd

  committed
  b2bdf02

Commits on Feb 16, 2020

• Better method name: calcPos -> calcCenteredPos.

  cnrudd

  committed
  4753e87

• React-rnd semver tweak.

  cnrudd

  committed
  cc5a41c

• Put scss var decl on one line.

  cnrudd

  committed
  633563b

• Merge branch 'develop' into hoistDialog

  cnrudd

  committed
  8ed6342

• Latest deps in yarn.lock

  cnrudd

  committed
  ea94ab1

• Model passing cleanup.

  cnrudd

  committed
  8b8283a

• Fix setPositionState

  cnrudd

  committed
  372a8c7

Commits on Feb 17, 2020

• Move showCloseButton to prop

  cnrudd

  committed
  65816e0

Commits on Feb 18, 2020

• Rework as controlled component;

  Show description for 7e6d049
  cnrudd

  committed
  7e6d049

Commits on Feb 19, 2020

• Fix closeOnEscape handling

  cnrudd

  committed
  9ac3175

• convert closeOnEscape to prop

  cnrudd

  committed
  ede3e35

Commits on Feb 21, 2020

• Fix handling of specified size and width when not resizable.

  cnrudd

  committed
  3fdf152

• Merge branch 'develop' into hoistDialog

  cnrudd

  committed
  5f5c8b8

• Use Hoist Dialog for messages.

  cnrudd

  committed
  272a2b0

• Match dialog styles to current hoist/bp dialog styles.

  cnrudd

  committed
  3d7d0c8

• Lee and Colin: codev

  lbwexler

  committed
  b10b57e

Commits on Feb 24, 2020

• WIP

  cnrudd

  committed
  31df902

• Use elementFromContent for the dialog content.

  cnrudd

  committed
  aa32bf8

• Get setting off model, not prop.

  cnrudd

  committed
  839bbf5

Commits on Feb 25, 2020

• Remove body overflow switch

  cnrudd

  committed
  2f5add3

• No longer allow create model from default.

  cnrudd

  committed
  8207761

• Remove portal div from DOM when popup closes

  cnrudd

  committed
  482af25

• use Hoist Dialog on Message components.

  cnrudd

  committed
  f8087c5

• ClientErrorDetail dialog uses Hoist Dialog.

  cnrudd

  committed
  573ad4f

• Keep centered dialogs centered on window resize.

  cnrudd

  committed
  2a56b6e

• Add inPortal switch

  cnrudd

  committed
  02e69ec

• Cleanup

  cnrudd

  committed
  15df57f

• Merge branch 'develop' into hoistDialogModel

  cnrudd

  committed
  ce58b7e

Commits on Mar 4, 2020

• Changes to positioning to better handle observable positions and sizes.

  cnrudd

  committed
  b3fc861

• Merge branch 'develop' into hoistDialogModel

  cnrudd

  committed
  95a5217

• Better use of computed and observables for position and sizing.

  cnrudd

  committed
  d8d7f2b

Commits on Mar 5, 2020

• Fix some state model edge cases.

  cnrudd

  committed
  5e75e54

• Working observables!

  cnrudd

  committed
  bd54225

• Make maximized dialog resize with body when body resizes.

  cnrudd

  committed
  026ce7e

Commits on Mar 16, 2020

• Merge branch 'develop' into hoistDialogModel

  cnrudd

  committed
  3a44217

• Fix maximize in non-portal dialog

  cnrudd

  committed
  c4a5aec

• Use initialX|Y|Width|Height

  cnrudd

  committed
  4d8fca3

• Use currentHeight|Width in sizing dialog content

  cnrudd

  committed
  014ef1e

• Refactor pos and size functionality.

  cnrudd

  committed
  9ccb92f

• Enforce x,y & width,height set together.

  cnrudd

  committed
  e2f315b

• Prevent draghandles when maximized

  cnrudd

  committed
  86075b2

• todo reminder

  cnrudd

  committed
  378b189

• Name cleanups.

  cnrudd

  committed
  7c7efde

Commits on Mar 17, 2020

• Move non-public methods to implementation section.

  cnrudd

  committed
  5e60c71

Commits on Mar 22, 2020

• Replace .bp3_dailog default css width of 500px with content width

  cnrudd

  committed
  405df39

• Put width setting on content, not on dialog.

  cnrudd

  committed
  35c2d6f

Commits on Mar 23, 2020

• Specify width on ClientError dialog, and make resizable.

  cnrudd

  committed
  c6a1596

• Better content rendering via css: avoid background -color bleed with display:flex

  cnrudd

  committed
  b127522

• Now that dialog is resizable, make jsoninput 100% height

  cnrudd

  committed
  91d1537

• Put width spec on Dialog, not on content.

  cnrudd

  committed
  36c2520

• New MenuButton component

  cnrudd

  committed
  62f631d

• Support resizable with no width & height, or just one dim. Also support just one dim if resizable = false;

  cnrudd

  committed
  e99536a

Commits on Mar 26, 2020

• Merge branch 'develop' into hoistDialogModel

  Show description for 46ee943
  lbwexler

  committed
  46ee943

• Merge remote-tracking branch 'origin/hoistDialogModel' into hoistDialogModel

  Show description for c163282
  lbwexler

  committed
  c163282

• + Pass model with Context.

  Show description for 5492d18
  lbwexler

  committed
  5492d18

• + Use LocalModel pattern

  Show description for 76883e7
  lbwexler

  committed
  76883e7

Commits on Mar 27, 2020

• Checkpoint

  lbwexler

  committed
  d85f253

Commits on Mar 28, 2020

• Refactor

  lbwexler

  committed
  5d47c7b

Commits on Mar 29, 2020

• Checkpoint

  lbwexler

  committed
  bb825bc

• Checkpoint

  lbwexler

  committed
  ec923ea

Commits on Mar 30, 2020

• Remove stray console log

  lbwexler

  committed
  1a13dc9

• Fix issue with Titleless dialog

  lbwexler

  committed
  f1d1caa

• Checkpoint

  lbwexler

  committed
  fdb82df

• unMaximize() => restore()

  lbwexler

  committed
  5a838d7

• Update dependencies

  lbwexler

  committed
  62f279d

• Update yarn.lock

  lbwexler

  committed
  67ceec2

• Merge branch 'develop' into dialogX

  Show description for 141da17
  lbwexler

  committed
  141da17

Commits on Mar 31, 2020

• Merge branch 'develop' into dialogX

  Show description for c78f349
  lbwexler

  committed
  c78f349

Commits on Apr 2, 2020

• Merge branch 'develop' into dialogX

  lbwexler

  committed
  d7f0b21

Commits on Apr 3, 2020

• + Incorporate parent resizing behavior

  Show description for 0e9241e
  lbwexler

  committed
  0e9241e

• Don't set position on user induced re-size

  lbwexler

  committed
  3afec6a

• Doc fix

  lbwexler

  committed
  3c7c855

Commits on Apr 11, 2020

• Merge branch 'develop' into dialogX

  lbwexler

  committed
  536f57f

Commits on Apr 12, 2020

• Cleanup checkpoint

  lbwexler

  committed
  8d63efb

Commits on Apr 13, 2020

• Continued Refactor

  lbwexler

  committed
  7005f6d

• Support Percentage Width and Height

  lbwexler

  committed
  c9bd74b

• Checkpoint

  lbwexler

  committed
  f55683f

• Merge branch 'develop' into dialogX

  Show description for dbedd17
  lbwexler

  committed
  dbedd17

• Update to new package import

  lbwexler

  committed
  206bc7c

Commits on Apr 14, 2020

• Provide proper renderMode/refreshMode support

  lbwexler

  committed
  0c82994

Commits on Apr 27, 2020

• Merge branch 'develop' into dialogX

  cnrudd

  committed
  4710630

• Latest yarn.lock

  cnrudd

  committed
  b29e92b

Commits on Jun 4, 2020

• Merge branch 'develop' into dialogX

  Show description for 0200375
  lbwexler

  committed
  0200375

• Merge branch 'dialogX' of https://github.com/xh/hoist-react into dialogX

  Show description for 0868e64
  lbwexler

  committed
  0868e64

Commits on Jun 26, 2020

• Merge branch 'develop' into dialogX

  cnrudd

  authored
  a654ae0

Commits on Sep 18, 2020

• Merge branch 'develop' into dialogX

  cnrudd

  committed
  debbec7