xen: Add test-ring0 tests #304
Conversation
dinhngtu
force-pushed
the
dnt-test-ring0
branch
3 times, most recently
from
8fcffa8 to
b4ce123
Compare
|
LGTM. As this adds a reboot to the xen test, we need to test it in CI conditions to see how it behaves, before merging. CC @gduperrey |
|
8.2 xen ✅ |
|
2025-06-19:
|
tests/xen/test_ring0.py
Outdated
| def host_with_ring0_tests(host_with_saved_yum_state: Host) \ | ||
| -> Generator[Host, None, None]: |
There was a problem hiding this comment.
Trailing backslashes are discouraged when possible in PEP8: https://peps.python.org/pep-0008/#maximum-line-length
Adding the newline before the closing parenthesis seems to be quite usual.
There was a problem hiding this comment.
On the contrary, this style is used just about everywhere in our tests.
There was a problem hiding this comment.
Well, we're only at the start of using type hints, and I see just a few occurrences of that pattern. I don't see a reason to select a style that does not conform to pep8 here, and would rather prefer that we adjust those few ones :)
There was a problem hiding this comment.
well, the additional newline may not be necessary, but I can live with it :)
Signed-off-by: Tu Dinh <[email protected]>
Run the test-ring0 tests that are straightforward to run.
The ones that are not (e.g. legacy tests, tests that crash the host or leak resources infinitely) are skipped, but included for completeness.
test_xst_memory_leakrequires a custom kernel withCONFIG_DEBUG_KMEMLEAKset.