Skip to content

Add a new test on 'perf probe' bug #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file.
15 changes: 15 additions & 0 deletions tests/packages/linux_image/conftest.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
import logging
import pytest
import urllib.request

# Explicitly import package-scoped fixtures (see explanation in pkgfixtures.py)
from pkgfixtures import host_with_saved_yum_state

@pytest.fixture(scope="package")
def host_with_perf(host_with_saved_yum_state):
host = host_with_saved_yum_state

logging.info(f"Getting perf package")

host.yum_install(['perf'])
yield host
29 changes: 29 additions & 0 deletions tests/packages/linux_image/test_perf_probe.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
# Requirements:
# From --hosts parameter:
# - host(A1): any xcp-ng host
import re

def perf_probe(host, probe):
host.ssh(['perf', 'probe', '--add', probe])
host.ssh(['perf', 'record', '-e', 'probe:' + probe, '-o', '~/perf.data', '-aR', '--', 'sleep', '10'])
host.ssh(['perf', 'probe', '--del', probe])

samples = host.ssh(['perf', 'report', '-i', '~/perf.data', '-D', '--stdio-color', 'never'])
host.ssh(['rm', '~/perf.data'])

return re.findall(r'RECORD_SAMPLE', samples)

def test_linux_image_perf_probe(host_with_perf):
# Probe that triggers very often:
probe = 'xen_flush_tlb_one_user'

match = perf_probe(host_with_perf, probe)

assert len(match) > 0, "No sample found for probe %s!" % probe

# Example of a function that isn't called often:
probe = 'xenbus_backend_ioctl'

match = perf_probe(host_with_perf, probe)

assert len(match) == 0, "Samples found for probe %s!" % probe
Comment on lines +16 to +29
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's hope that isn't a flaky test :). We can always ajust later if there are issues with it.

Loading