Remove unused virtual clear power off pin for klipper 0.13 #335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Tasshack, thanks for the Pull Request. Can you confirm that it indeed works to receive multiple button presses with the changed logic? My understanding based on a chat that I had with @loss-and-quick is that it should, but I can't test it myself. Would be good to have quick confirmation by a 5M Pro owner, than I can merge it. |
|
Printer is busy right now but I will try klipper mod and make sure power button is working as soon as it finishes the job. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a virtual latching mechanism for the power button inside the stock MCU firmware which always returns the button state as PRESSED until it gets a signal from virtual PG1 pin.
This has been implemented for stock screen to not miss any button presses so it can be omitted for non stock screen usage with klipper 0.13 MCU firmware.